Webhook improvements (#7879)

* refactor: Move translate test utility to helpers directory

* Add kind property to webhooks

* feat: Add options to create webhook route

* refactor: Move webhook ops into single file

* refactor: Create webhook objects for specific webhook behavior

* chore(tests): Add default sleep helper value of 1 second

* feat(api): Add method for groups to send out webhook

* feat(api): Add taskCreated webhook task creation

* feat(api): Send chat webhooks after a chat is sent

* refactor: Move webhook routes to own controller

* lint: Correct linting errors

* fix(api): Correct taskCreated webhook method

* fix(api): Fix webhook logging to only log when there is an error

* fix: Update groupChatRecieved webhook creation

* chore: Add integration tests for webhooks

* fix: Set webhook creation response to 201

* fix: Correct how task scored webhook data is sent

* Revert group chat recieved webhook to only support one group

* Remove quest activity option for webhooks

* feat: Send webhook for each task created

* feat: Allow webhooks without a type to default to taskScored

* feat: Add logic for adding ids to webhook

* feat: optimize webhook url check by shortcircuiting if no url is passed

* refactor: Use full name for webhook variable

* feat: Add missing params to client webhook

* lint: Add missing semicolon

* chore(tests): Fix inccorect webhook tests

* chore: Add migration to update task scored webhooks

* feat: Allow default value of webhook add route to be enabled

* chore: Update webhook documentation

* chore: Remove special handling for v2

* refactor: adjust addComputedStatsToJSONObject to work for webhooks

* refactor: combine taskScored and taskActivity webhooks

* feat(api): Add task activity to task update and delete routes

* chore: Change references to taskScored to taskActivity

* fix: Correct stats object being passed in for transform

* chore: Remove extra line break

* fix: Pass in the language to use for the translations

* refactor(api): Move webhooks from user.preferences.webhooks to user.webhooks

* chore: Update migration to set webhook array

* lint: Correct brace spacing

* chore: convert webhook lib to use user.webhooks

* refactor(api): Consolidate filters

* chore: clarify migration instructions

* fix(test): Correct user creation in user anonymized tests

* chore: add test that webhooks cannot be updated via PUT /user

* refactor: Simplify default webhook id value

* refactor(client): Push newly created webhook instead of doing a sync

* chore(test): Add test file for webhook model

* refactor: Remove webhook validation

* refactor: Remove need for watch on webhooks

* refactor(client): Update webhooks object without syncing

* chore: update webhook documentation

* Fix migrations issues

* chore: remove v2 test helper

* fix(api): Provide webhook type in task scored webhook

* fix(client): Fix webhook deletion appearing to delete all webhooks

* feat(api): add optional label field for webhooks

* feat: provide empty string as default for webhook label

* chore: Update webhook migration

* chore: update webhook migration name

website/common/script/ops/addWebhook.js

@@ -1,23 +0,0 @@
-import refPush from '../libs/refPush';
-import validator from 'validator';
-import i18n from '../i18n';
-import {
-  BadRequest,
-} from '../libs/errors';
-import _ from 'lodash';
-
-module.exports = function addWebhook (user, req = {}) {
-  let wh = user.preferences.webhooks;
-
-  if (!validator.isURL(_.get(req, 'body.url'))) throw new BadRequest(i18n.t('invalidUrl', req.language));
-  if (!validator.isBoolean(_.get(req, 'body.enabled'))) throw new BadRequest(i18n.t('invalidEnabled', req.language));
-
-  user.markModified('preferences.webhooks');
-
-  return [
-    refPush(wh, {
-      url: req.body.url,
-      enabled: req.body.enabled,
-    }),
-  ];
-};

website/common/script/ops/deleteWebhook.js

@@ -1,10 +0,0 @@
-import _ from 'lodash';
-
-module.exports = function deleteWebhook (user, req) {
-  delete user.preferences.webhooks[_.get(req, 'params.id')];
-  user.markModified('preferences.webhooks');
-
-  return [
-    user.preferences.webhooks,
-  ];
-};

website/common/script/ops/index.js

@@ -12,9 +12,6 @@ import addTag from './addTag';
 import sortTag from './sortTag';
 import updateTag from './updateTag';
 import deleteTag from './deleteTag';
-import addWebhook from './addWebhook';
-import updateWebhook from './updateWebhook';
-import deleteWebhook from './deleteWebhook';
 import clearPMs from './clearPMs';
 import deletePM from './deletePM';
 import blockUser from './blockUser';
@@ -58,9 +55,6 @@ module.exports = {
   sortTag,
   updateTag,
   deleteTag,
-  addWebhook,
-  updateWebhook,
-  deleteWebhook,
   clearPMs,
   deletePM,
   blockUser,

website/common/script/ops/updateWebhook.js

@@ -1,16 +0,0 @@
-import validator from 'validator';
-import i18n from '../i18n';
-import {
-  BadRequest,
-} from '../libs/errors';
-
-module.exports = function updateWebhook (user, req) {
-  if (!validator.isURL(req.body.url)) throw new BadRequest(i18n.t('invalidUrl', req.language));
-  if (!validator.isBoolean(req.body.enabled)) throw new BadRequest(i18n.t('invalidEnabled', req.language));
-
-  user.markModified('preferences.webhooks');
-  user.preferences.webhooks[req.params.id].url = req.body.url;
-  user.preferences.webhooks[req.params.id].enabled = req.body.enabled;
-
-  return [user.preferences.webhooks[req.params.id]];
-};