krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-19 07:37:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

update quest leave route

Browse Source
This commit is contained in:
Matteo Pagliazzi
2016-02-11 15:07:45 +01:00
parent c6c852cd6d
commit 354b6bc39e
2 changed files with 90 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
website/src/controllers/api-v3/quests.js
View File

@@ -19,7 +19,6 @@ import {
sendTxn as sendTxnEmail,
} from '../../libs/api-v3/email';
import { quests as questScrolls } from '../../../../common/script/content';
import Q from 'q';
function canStartQuestAutomatically (group) {
// If all members are either true (accepted) or false (rejected) return true
@@ -184,14 +183,14 @@ api.acceptQuest = {
};
/**
* @api {post} /groups/:groupId/quests/leave Leaves a quest
* @api {post} /groups/:groupId/quests/leave Leaves the active quest
* @apiVersion 3.0.0
* @apiName LeaveQuest
* @apiGroup Group
*
* @apiParam {string} groupId The group _id (or 'party')
*
* @apiSuccess {Object} Empty Object
* @apiSuccess {Object} quest Quest Object
*/
api.leaveQuest = {
method: 'POST',
@@ -207,19 +206,12 @@ api.leaveQuest = {
if (validationErrors) throw validationErrors;
let group = await Group.getGroup({user, groupId, fields: 'type quest'});
if (!group) throw new NotFound(res.t('groupNotFound'));
if (!(group.quest && group.quest.active)) {
throw new NotFound(res.t('noActiveQuestToLeave'));
}
if (group.quest.leader === user._id) {
throw new NotAuthorized(res.t('questLeaderCannotLeaveQuest'));
}
if (!(group.quest.members && group.quest.members[user._id])) {
throw new NotAuthorized(res.t('notPartOfQuest'));
}
if (group.type !== 'party') throw new NotAuthorized(res.t('guildQuestsNotSupported'));
if (!group.quest.active) throw new NotFound(res.t('noActiveQuestToLeave'));
if (group.quest.leader === user._id) throw new NotAuthorized(res.t('questLeaderCannotLeaveQuest'));
if (!group.quest.members[user._id]) throw new NotAuthorized(res.t('notPartOfQuest'));
group.quest.members[user._id] = false;
group.markModified('quest.members');