krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-18 23:27:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #6600 from KristianTashkov/challenge-winner-tests

Browse Source 
Challenge select winner route tests
This commit is contained in:
Matteo Pagliazzi
2016-01-29 19:21:52 +01:00
parent 0084a0d057 c52064b3df
commit 340e918def
2 changed files with 144 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
website/src/controllers/api-v3/challenges.js
View File

@@ -438,9 +438,9 @@ api.deleteChallenge = {
};
/**
* @api {delete} /challenges/:challengeId Delete a challenge
* @api {post} /challenges/:challengeId/selectWinner/:winnerId Select winner for challenge
* @apiVersion 3.0.0
* @apiName DeleteChallenge
* @apiName SelectChallengeWinner
* @apiGroup Challenge
*
* @apiSuccess {object} empty An empty object
@@ -452,7 +452,7 @@ api.selectChallengeWinner = {
async handler (req, res) {
let user = res.locals.user;
req.checkParams('challenge', res.t('challengeIdRequired')).notEmpty().isUUID();
req.checkParams('challengeId', res.t('challengeIdRequired')).notEmpty().isUUID();
req.checkParams('winnerId', res.t('winnerIdRequired')).notEmpty().isUUID();
let validationErrors = req.validationErrors();
@@ -463,11 +463,11 @@ api.selectChallengeWinner = {
if (!challenge.canModify(user)) throw new NotAuthorized(res.t('onlyLeaderDeleteChal'));
let winner = await User.findOne({_id: req.params.winnerId}).exec();
if (!winner || winner.challenges.indexOf(challenge._id) === -1) throw new NotFound(res.t('winnerNotFound', {userId: req.parama.winnerId}));
if (!winner || winner.challenges.indexOf(challenge._id) === -1) throw new NotFound(res.t('winnerNotFound', {userId: req.params.winnerId}));
res.respond(200, {});
// Close channel in background
_closeChal(challenge, {broken: 'CHALLENGE_DELETED', winner});
_closeChal(challenge, {broken: 'CHALLENGE_CLOSED', winner});
},
};