From 2df6b6461bc2a581d236fff9c1a234dc6b647b5d Mon Sep 17 00:00:00 2001
From: SabreCat <sabe@habitica.com>
Date: Tue, 4 Apr 2023 18:25:14 -0500
Subject: [PATCH] fix(links): better http/s handling

---
 website/client/src/components/appFooter.vue | 4 ++--
 website/client/src/mixins/externalLinks.js  | 5 +++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/website/client/src/components/appFooter.vue b/website/client/src/components/appFooter.vue
index 69ec6b0e2f..dbbf211255 100644
--- a/website/client/src/components/appFooter.vue
+++ b/website/client/src/components/appFooter.vue
@@ -213,7 +213,7 @@
             </a>
             <a
               class="social-circle"
-              href="https://twitter.com/habitica"
+              href="https://twitter.com/habitica/"
               target="_blank"
             >
               <div
@@ -223,7 +223,7 @@
             </a>
             <a
               class="social-circle"
-              href="https://www.facebook.com/Habitica"
+              href="https://www.facebook.com/Habitica/"
               target="_blank"
             >
               <div
diff --git a/website/client/src/mixins/externalLinks.js b/website/client/src/mixins/externalLinks.js
index bce267da7c..537f20462d 100644
--- a/website/client/src/mixins/externalLinks.js
+++ b/website/client/src/mixins/externalLinks.js
@@ -8,10 +8,11 @@ export default {
 
       for (let i = 0; i < allLinks.length; i += 1) {
         const link = allLinks[i];
+        const domainIndex = link.href.indexOf('//') + 2;
 
         if ((link.classList.value.indexOf('external-link') === -1)
-          && link.href.slice(0, 4) === 'http'
-          && !some(TRUSTED_DOMAINS.split(','), domain => link.href.indexOf(domain) === 0)) {
+          && domainIndex !== 1
+          && !some(TRUSTED_DOMAINS.split(','), domain => link.href.indexOf(domain) === domainIndex)) {
           link.classList.add('external-link');
           link.addEventListener('click', e => {
             if (e.ctrlKey) {