krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-16 22:27:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

Added float rounding (#9657)

Browse Source 
* Added float rounding

* Changed to isNaN
This commit is contained in:
Keith Holliday
2017-12-11 11:48:50 -06:00
committed by GitHub
parent 2570c59130
commit 2bb5751f33
2 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
test/api/v3/integration/tasks/POST-tasks_user.test.js
View File

@@ -302,6 +302,17 @@ describe('POST /tasks/user', () => {
expect(task.alias).to.eql('a_alias012'); expect(task.alias).to.eql('a_alias012');
}); });
// This is a special case for iOS requests
it('will round a priority (difficulty)', async () => {
let task = await user.post('/tasks/user', {
text: 'test habit',
type: 'habit',
priority: 0.10000000000005,
});
expect(task.priority).to.eql(0.1);
});
}); });
context('habits', () => { context('habits', () => {

5
website/server/libs/taskManager.js
View File

@@ -86,6 +86,11 @@ export async function createTasks (req, res, options = {}) {
let taskType = taskData.type; let taskType = taskData.type;
let newTask = new Tasks[taskType](Tasks.Task.sanitize(taskData)); let newTask = new Tasks[taskType](Tasks.Task.sanitize(taskData));
// Attempt to round priority
if (newTask.priority && !Number.isNaN(Number.parseFloat(newTask.priority))) {
newTask.priority = Number(newTask.priority.toFixed(1));
}
if (challenge) { if (challenge) {
newTask.challenge.id = challenge.id; newTask.challenge.id = challenge.id;
} else if (group) { } else if (group) {