From 8e5cdbd742f288155a813b61ce3104f3c61d7ba5 Mon Sep 17 00:00:00 2001 From: hairlessbear Date: Wed, 13 May 2015 12:12:03 -0400 Subject: [PATCH] Fixed challenges achievement always displaying (again) Unearned achievements are hidden when viewing others' profiles, but are visible when a user views their own profile. Currently, the challenges achievement is displayed when viewing other users' profiles, even when they have not won any. This PR makes the challenges achievement display to other users' only when one or more challenges have been won. --- website/views/shared/profiles/achievements.jade | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/views/shared/profiles/achievements.jade b/website/views/shared/profiles/achievements.jade index bfa614f5dc..b2bec658d8 100644 --- a/website/views/shared/profiles/achievements.jade +++ b/website/views/shared/profiles/achievements.jade @@ -144,7 +144,7 @@ div(ng-if='::profile.achievements.originalUser') small!=env.t('originalUserText') hr -div(ng-if='::profile.achievements.challenges || user._id == profile._id') +div(ng-if='::profile.achievements.challenges.length || user._id == profile._id') // This is a very strange icon to use. revisit .achievement.achievement-karaoke(ng-if='::profile.achievements.challenges.length') div(ng-class='::{muted: !profile.achievements.challenges.length}')