remove BETA comment and fix tests

This commit is contained in:
Matteo Pagliazzi
2019-09-20 16:44:46 +02:00
parent 7b69967412
commit 2a9f5e1667
2 changed files with 12 additions and 12 deletions

View File

@@ -1,23 +1,22 @@
import { generateUser } from '../../../../helpers/api-integration/v3'; import { generateUser } from '../../../../helpers/api-integration/v3';
describe('GET /user/webhook', () => { describe('GET /user/webhook', () => {
let user, webhooks; let user;
beforeEach(async () => { beforeEach(async () => {
user = await generateUser(); user = await generateUser();
webhooks = []; await user.post('/user/webhook', {
webhooks.push(await user.post('/user/webhook', {
url: 'http://some-url.com', url: 'http://some-url.com',
label: 'Label', label: 'Label',
enabled: true, enabled: true,
type: 'taskActivity', type: 'taskActivity',
options: { created: true, scored: true }, options: { created: true, scored: true },
})); });
webhooks.push(await user.post('/user/webhook', { await user.post('/user/webhook', {
url: 'http://some-other-url.com', url: 'http://some-other-url.com',
enabled: false, enabled: false,
})); });
await user.sync(); await user.sync();
}); });
@@ -25,9 +24,10 @@ describe('GET /user/webhook', () => {
it('returns users webhooks', async () => { it('returns users webhooks', async () => {
let response = await user.get('/user/webhook'); let response = await user.get('/user/webhook');
// updatedAt times don't match for some reason, so need to omit those from comparison expect(response).to.eql(user.webhooks.map(w => {
let omitUpdatedAt = a => a.map(v => _.omit(v, 'updatedAt')); w.createdAt = w.createdAt.toISOString();
w.updatedAt = w.updatedAt.toISOString();
expect(omitUpdatedAt(response)).to.eql(omitUpdatedAt(webhooks)); return w;
}));
}); });
}); });

View File

@@ -96,7 +96,7 @@ api.addWebhook = {
}; };
/** /**
* @api {get} /api/v3/user/webhook Get webhooks - BETA * @api {get} /api/v3/user/webhook Get webhooks
* @apiName UserGetWebhook * @apiName UserGetWebhook
* @apiGroup Webhook * @apiGroup Webhook
* *
@@ -107,7 +107,7 @@ api.getWebhook = {
middlewares: [authWithHeaders()], middlewares: [authWithHeaders()],
url: '/user/webhook', url: '/user/webhook',
async handler (req, res) { async handler (req, res) {
let user = res.locals.user; const user = res.locals.user;
res.respond(200, user.webhooks); res.respond(200, user.webhooks);
}, },