From 29f1817a7c4be7e3186ca3ec17d8c80731b031e4 Mon Sep 17 00:00:00 2001 From: negue Date: Sat, 20 Jun 2020 20:09:28 +0200 Subject: [PATCH] TaskModal: Checklist component extracted (#12287) * wip: checklist component extracted * fixing icons: Trash can - Delete Little X - Remove Big X - Close Block - Block * remove checklist code from taskModal and replace with the component + fix styles * save checklist item on blur * remove console.info * fix pr comments + empty checklist item + icon --- website/client/config/storybook/config.js | 12 +- website/client/src/assets/members/remove.svg | 3 - website/client/src/assets/svg/block.svg | 3 + website/client/src/assets/svg/chevron.svg | 3 + website/client/src/assets/svg/grip.svg | 3 + website/client/src/assets/svg/remove.svg | 6 +- .../src/components/groups/membersModal.vue | 22 +- .../components/messages/conversationItem.vue | 6 +- .../src/components/selectMembersModal.vue | 2 +- .../tasks/modal-controls/checklist.stories.js | 46 +++ .../tasks/modal-controls/checklist.vue | 272 ++++++++++++++++++ .../client/src/components/tasks/taskModal.vue | 140 +-------- website/client/src/components/ui/checkbox.vue | 6 + .../src/components/userMenu/profile.vue | 14 +- 14 files changed, 376 insertions(+), 162 deletions(-) delete mode 100644 website/client/src/assets/members/remove.svg create mode 100644 website/client/src/assets/svg/block.svg create mode 100644 website/client/src/assets/svg/chevron.svg create mode 100644 website/client/src/assets/svg/grip.svg create mode 100644 website/client/src/components/tasks/modal-controls/checklist.stories.js create mode 100644 website/client/src/components/tasks/modal-controls/checklist.vue diff --git a/website/client/config/storybook/config.js b/website/client/config/storybook/config.js index 827fb94455..01bba95033 100644 --- a/website/client/config/storybook/config.js +++ b/website/client/config/storybook/config.js @@ -31,14 +31,22 @@ import '../../src/assets/css/sprites/spritesmith-main-24.css'; import '../../src/assets/css/sprites/spritesmith-main-25.css'; import '../../src/assets/css/sprites/spritesmith-main-26.css'; import Vue from 'vue'; +import BootstrapVue from 'bootstrap-vue'; import StoreModule from '@/libs/store'; +// couldn't inject the languages easily, +// so just a "$t()" string to show that this will be translated +Vue.prototype.$t = function translateString (...args) { + return `$t(${JSON.stringify(args)})`; +}; + +Vue.use(BootstrapVue); +Vue.use(StoreModule); + const req = require.context('../../src', true, /.stories.js$/); function loadStories () { req.keys().forEach(filename => req(filename)); } -Vue.use(StoreModule); - configure(loadStories, module); diff --git a/website/client/src/assets/members/remove.svg b/website/client/src/assets/members/remove.svg deleted file mode 100644 index a717d49915..0000000000 --- a/website/client/src/assets/members/remove.svg +++ /dev/null @@ -1,3 +0,0 @@ - - - diff --git a/website/client/src/assets/svg/block.svg b/website/client/src/assets/svg/block.svg new file mode 100644 index 0000000000..4b56e4bb94 --- /dev/null +++ b/website/client/src/assets/svg/block.svg @@ -0,0 +1,3 @@ + + + diff --git a/website/client/src/assets/svg/chevron.svg b/website/client/src/assets/svg/chevron.svg new file mode 100644 index 0000000000..f27134b02e --- /dev/null +++ b/website/client/src/assets/svg/chevron.svg @@ -0,0 +1,3 @@ + + + diff --git a/website/client/src/assets/svg/grip.svg b/website/client/src/assets/svg/grip.svg new file mode 100644 index 0000000000..3c31fd3fce --- /dev/null +++ b/website/client/src/assets/svg/grip.svg @@ -0,0 +1,3 @@ + + + diff --git a/website/client/src/assets/svg/remove.svg b/website/client/src/assets/svg/remove.svg index 4b56e4bb94..a57da07186 100644 --- a/website/client/src/assets/svg/remove.svg +++ b/website/client/src/assets/svg/remove.svg @@ -1,3 +1,5 @@ - - + + + + diff --git a/website/client/src/components/groups/membersModal.vue b/website/client/src/components/groups/membersModal.vue index 6e7b15f520..17eb17d2a8 100644 --- a/website/client/src/components/groups/membersModal.vue +++ b/website/client/src/components/groups/membersModal.vue @@ -161,8 +161,8 @@ >
{{ $t('removeManager2') }}
@@ -181,8 +181,8 @@ >
{{ $t('removeMember') }}
@@ -231,8 +231,8 @@
{{ $t('removeInvite') }}
@@ -279,6 +279,8 @@ + + diff --git a/website/client/src/components/tasks/taskModal.vue b/website/client/src/components/tasks/taskModal.vue index a7d508e54a..9e080f625a 100644 --- a/website/client/src/components/tasks/taskModal.vue +++ b/website/client/src/components/tasks/taskModal.vue @@ -126,43 +126,7 @@ v-if="checklistEnabled" class="option mt-0" > - -
- -
- - - -
-
-
-
- +
+ +