krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-18 15:17:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix failing tests

Browse Source
This commit is contained in:
Matteo Pagliazzi
2016-03-11 09:51:59 +01:00
parent 78c1ee2053
commit 29b6e958c6
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/api/v3/integration/tasks/PUT-tasks_id.test.js
View File

@@ -79,7 +79,7 @@ describe('PUT /tasks/:id', () => {
let id2 = generateUUID(); let id2 = generateUUID();
let savedDaily = await user.put(`/tasks/${daily._id}`, { let savedDaily = await user.put(`/tasks/${daily._id}`, {
checklist: [ reminders: [
{id: id1, time: new Date(), startDate: new Date()}, {id: id1, time: new Date(), startDate: new Date()},
{id: id2, time: new Date(), startDate: new Date()}, {id: id2, time: new Date(), startDate: new Date()},
], ],

2
test/api/v3/integration/tasks/checklists/PUT-tasks_taskId_checklist_itemId.test.js
View File

@@ -25,7 +25,7 @@ describe('PUT /tasks/:taskId/checklist/:itemId', () => {
savedTask = await user.put(`/tasks/${task._id}/checklist/${savedTask.checklist[0]._id}`, { savedTask = await user.put(`/tasks/${task._id}/checklist/${savedTask.checklist[0]._id}`, {
text: 'updated', text: 'updated',
completed: true, completed: true,
_id: 123, _id: 123, // ignored
}); });
expect(savedTask.checklist.length).to.equal(1); expect(savedTask.checklist.length).to.equal(1);

2
website/src/controllers/api-v3/tasks.js
View File

@@ -570,7 +570,7 @@ api.addChecklistItem = {
if (task.type !== 'daily' && task.type !== 'todo') throw new BadRequest(res.t('checklistOnlyDailyTodo')); if (task.type !== 'daily' && task.type !== 'todo') throw new BadRequest(res.t('checklistOnlyDailyTodo'));
task.checklist.push(Tasks.Task.sanitizeChecklist(req.body)); task.checklist.push(Tasks.Task.sanitizeChecklist(req.body)); // TODO why not allow to supply _id on creation?
let savedTask = await task.save(); let savedTask = await task.save();
res.respond(200, savedTask); // TODO what to return res.respond(200, savedTask); // TODO what to return

2
website/src/models/task.js
View File

@@ -70,7 +70,7 @@ TaskSchema.statics.sanitizeChecklist = function sanitizeChecklist (checklistObj)
}; };
// Sanitize reminder objects (disallowing id) // Sanitize reminder objects (disallowing id)
TaskSchema.statics.sanitizeChecklist = function sanitizeChecklist (reminderObj) { TaskSchema.statics.sanitizeReminder = function sanitizeReminder (reminderObj) {
delete reminderObj.id; delete reminderObj.id;
return reminderObj; return reminderObj;
}; };