From 28b56256d2d5ee1ec71d06a9f58f6dbf33b30e88 Mon Sep 17 00:00:00 2001 From: Keith Holliday Date: Wed, 12 Jul 2017 14:35:08 -0600 Subject: [PATCH] Added catch for cron error (#8864) * Added catch for cron error * Updated logger usage --- website/server/middlewares/cron.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/website/server/middlewares/cron.js b/website/server/middlewares/cron.js index addf27c1df..55bff14066 100644 --- a/website/server/middlewares/cron.js +++ b/website/server/middlewares/cron.js @@ -5,6 +5,7 @@ import { model as Group } from '../models/group'; import { model as User } from '../models/user'; import { recoverCron, cron } from '../libs/cron'; import { v4 as uuid } from 'uuid'; +import logger from '../libs/logger'; async function cronAsync (req, res) { let user = res.locals.user; @@ -106,13 +107,17 @@ async function cronAsync (req, res) { await recoverCron(recoveryStatus, res.locals); } else { + logger.error(err, {isUserUpdateErroringDuringCron: true}); // For any other error make sure to reset _cronSignature so that it doesn't prevent cron from running // at the next request await User.update({ _id: user._id, }, { _cronSignature: 'NOT_RUNNING', - }).exec(); + }).exec() + .catch((newError) => { + logger.error(newError, {isUserUpdateErroringDuringCron: true}); + }); throw err; // re-throw the original error }