krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-16 14:17:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix: Preventing adding duplicated task ID to taskOrder fix for #11385 (#11408)

Browse Source 
* Preventing adding duplicated task ID to taskOrder object when creating new tasks

* refactor: not using Sets for taskOrderToAdd[]

* refactor: remove unnecessary checking
This commit is contained in:
cheng-shiqi
2019-11-02 02:00:21 +08:00
committed by Matteo Pagliazzi
parent 52719ac685
commit 2741721161
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
website/server/libs/taskManager.js
View File

@@ -116,7 +116,7 @@ export async function createTasks (req, res, options = {}) {
// Otherwise update the user/challenge/group
if (!taskOrderToAdd[`${taskType}s`]) taskOrderToAdd[`${taskType}s`] = [];
taskOrderToAdd[`${taskType}s`].unshift(newTask._id);
if (!owner.tasksOrder[`${taskType}s`].includes(newTask._id)) taskOrderToAdd[`${taskType}s`].unshift(newTask._id);
return newTask;
});