diff --git a/test/api/v3/unit/libs/cron.test.js b/test/api/v3/unit/libs/cron.test.js index d4a83634f3..382246a3c8 100644 --- a/test/api/v3/unit/libs/cron.test.js +++ b/test/api/v3/unit/libs/cron.test.js @@ -298,19 +298,19 @@ describe('cron', () => { expect(tasksByType.dailys[0].completed).to.be.false; }); - it('should set task checklist to completed for completed dailys', () => { + it('should reset task checklist for completed dailys', () => { tasksByType.dailys[0].checklist.push({title: 'test', completed: false}); tasksByType.dailys[0].completed = true; cron({user, tasksByType, daysMissed, analytics}); - expect(tasksByType.dailys[0].checklist[0].completed).to.be.true; + expect(tasksByType.dailys[0].checklist[0].completed).to.be.false; }); - it('should set task checklist to completed for dailys with scheduled misses', () => { + it('should reset task checklist for dailys with scheduled misses', () => { daysMissed = 10; tasksByType.dailys[0].checklist.push({title: 'test', completed: false}); tasksByType.dailys[0].startDate = moment(new Date()).subtract({days: 1}); cron({user, tasksByType, daysMissed, analytics}); - expect(tasksByType.dailys[0].checklist[0].completed).to.be.true; + expect(tasksByType.dailys[0].checklist[0].completed).to.be.false; }); it('should do damage for missing a daily', () => { diff --git a/website/src/libs/api-v3/cron.js b/website/src/libs/api-v3/cron.js index a8270c4bc8..25fcf9bd98 100644 --- a/website/src/libs/api-v3/cron.js +++ b/website/src/libs/api-v3/cron.js @@ -182,7 +182,7 @@ export function cron (options = {}) { task.completed = false; if (completed || scheduleMisses > 0) { - task.checklist.forEach(i => i.completed = true); // FIXME this should not happen for grey tasks unless they are completed + task.checklist.forEach(i => i.completed = false); // FIXME this should not happen for grey tasks unless they are completed } });