fix(tests): lint, GET group-plans

This commit is contained in:
SabreCat
2023-08-02 17:00:41 -05:00
parent b5a0dad7f7
commit 1df3f9d9f3
4 changed files with 19 additions and 20 deletions

View File

@@ -1,6 +1,5 @@
import { import {
generateUser, createAndPopulateGroup,
generateGroup,
} from '../../../../helpers/api-integration/v3'; } from '../../../../helpers/api-integration/v3';
describe('GET /group-plans', () => { describe('GET /group-plans', () => {
@@ -8,20 +7,15 @@ describe('GET /group-plans', () => {
let groupPlan; let groupPlan;
before(async () => { before(async () => {
user = await generateUser({ balance: 4 }); ({ group: groupPlan, groupLeader: user } = await createAndPopulateGroup({
groupPlan = await generateGroup(user, groupDetails: {
{ name: 'group plan - is member',
name: 'public guild - is member',
type: 'guild', type: 'guild',
privacy: 'public', privacy: 'private',
}, },
{ upgradeToGroupPlan: true,
purchased: { leaderDetails: { balance: 4 },
plan: { }));
customerId: 'existings',
},
},
});
}); });
it('returns group plans for the user', async () => { it('returns group plans for the user', async () => {

View File

@@ -19,7 +19,10 @@ describe('GET /groups', () => {
before(async () => { before(async () => {
await resetHabiticaDB(); await resetHabiticaDB();
({ group: privateGuildUserIsMemberOf, groupLeader: leader, members } = await createAndPopulateGroup({ ({ group: privateGuildUserIsMemberOf,
groupLeader: leader,
members,
} = await createAndPopulateGroup({
groupDetails: { groupDetails: {
name: 'private guild - is member', name: 'private guild - is member',
type: 'guild', type: 'guild',

View File

@@ -176,8 +176,9 @@ describe('GET /groups/:groupId/invites', () => {
}).timeout(30000); }).timeout(30000);
it('supports using req.query.lastId to get more invites', async function test () { it('supports using req.query.lastId to get more invites', async function test () {
let group; let invitees;
this.timeout(30000); // @TODO: times out after 8 seconds this.timeout(30000); // @TODO: times out after 8 seconds
const { group, groupLeader: user, invitees } = await createAndPopulateGroup({ ({ group, groupLeader: user, invitees } = await createAndPopulateGroup({
groupDetails: { groupDetails: {
type: 'guild', type: 'guild',
privacy: 'private', privacy: 'private',
@@ -186,7 +187,7 @@ describe('GET /groups/:groupId/invites', () => {
leaderDetails: { balance: 4 }, leaderDetails: { balance: 4 },
invites: 32, invites: 32,
upgradeToGroupPlan: true, upgradeToGroupPlan: true,
}); }));
const expectedIds = invitees.map(generatedInvite => generatedInvite._id); const expectedIds = invitees.map(generatedInvite => generatedInvite._id);

View File

@@ -76,13 +76,14 @@ describe('GET /groups/:groupId/members', () => {
}); });
it('req.query.includeAllPublicFields === true works with guilds', async () => { it('req.query.includeAllPublicFields === true works with guilds', async () => {
const { group, groupLeader: user } = await createAndPopulateGroup({ let group;
({ group, groupLeader: user } = await createAndPopulateGroup({
type: 'guild', type: 'guild',
privacy: 'private', privacy: 'private',
name: generateUUID(), name: generateUUID(),
upgradeToGroupPlan: true, upgradeToGroupPlan: true,
members: 1, members: 1,
}); }));
const [memberRes] = await user.get(`/groups/${group._id}/members?includeAllPublicFields=true`); const [memberRes] = await user.get(`/groups/${group._id}/members?includeAllPublicFields=true`);