krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-16 22:27:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: return full inbox on user-v3-api (#12146)

Browse Source 
* fix inbox on user-v3-api + test

* add @benkelaar suggestions
This commit is contained in:
negue
2020-05-02 21:48:16 +02:00
committed by GitHub
parent 26767f598b
commit 1c94c1a968
4 changed files with 28 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
test/api/v3/integration/user/GET-user.test.js
View File

@@ -1,3 +1,4 @@
import range from 'lodash/range';
import {
generateUser,
} from '../../../../helpers/api-integration/v3';
@@ -46,4 +47,23 @@ describe('GET /user', () => {
expect(returnedUser.apiToken).to.not.exist;
expect(returnedUser.secret).to.not.exist;
});
it('returns the full inbox', async () => {
const otherUser = await generateUser();
const amountOfMessages = 12;
const allMessagesPromise = range(amountOfMessages)
.map(i => otherUser.post('/members/send-private-message', {
toUserId: user.id,
message: `Message Num: ${i}`,
}));
await Promise.all(allMessagesPromise);
const returnedUser = await user.get('/user');
expect(returnedUser._id).to.equal(user._id);
expect(returnedUser.inbox).to.exist;
expect(Object.keys(returnedUser.inbox.messages)).to.have.a.lengthOf(amountOfMessages);
});
});

2
test/api/v4/inbox/GET-inbox-conversations.test.js
View File

@@ -63,7 +63,7 @@ describe('GET /inbox/conversations', () => {
expect(messages[4].text).to.equal('first');
});
it('returns four messages when using page-query ', async () => {
it('returns five messages when using page-query ', async () => {
const promises = [];
for (let i = 0; i < 10; i += 1) {