krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-16 22:27:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix #12118: pass mandatory second parameter to markdown-it parse method

Browse Source
This commit is contained in:
Matteo Pagliazzi
2020-04-24 12:06:05 +02:00
parent c4343379a1
commit 188023b197
2 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
test/api/unit/libs/highlightMentions.test.js
View File

@@ -105,4 +105,18 @@ describe('highlightMentions', () => {
expect(result[0]).to.equal('[@user](/profile/111) `@user`');
});
});
it('github issue 12118, method crashes when square brackets are used', async () => {
const text = '[test]';
let err;
try {
await highlightMentions(text);
} catch (e) {
err = e;
}
expect(err).to.be.undefined;
});
});

4
website/server/libs/highlightMentions.js
View File

@@ -76,7 +76,9 @@ function createCodeBlockRegex ({ content, type, markup }) {
*/
function findTextAndCodeBlocks (text) {
// For token description see https://markdown-it.github.io/markdown-it/#Token
const tokens = habiticaMarkdown.parse(text);
// The second parameter is mandatory even if not used, see
// https://markdown-it.github.io/markdown-it/#MarkdownIt.parse
const tokens = habiticaMarkdown.parse(text, {});
const codeBlocks = findCodeBlocks(tokens);
const blocks = [];