refactor: Organize protractor setup

package.json

@@ -99,7 +99,7 @@
     "test:karma:watch": "karma start",
     "test:prepare:webdriver": "webdriver-manager update",
     "test:e2e:webdriver": "webdriver-manager start",
-    "test:e2e": "protractor protractor.conf.js",
+    "test:e2e": "protractor test/e2e/protractor.conf.js",
     "test:nodemon": "gulp test:nodemon",
     "start": "gulp run:dev",
     "sprites": "gulp sprites:compile",

tasks/gulp-tests.js

@@ -269,9 +269,6 @@ gulp.task('test:e2e', ['test:prepare', 'test:prepare:server'], (cb) => {
     let runner = exec(
       'npm run test:e2e',
       (err, stdout, stderr) => {
-        /*
-         * Note: As it stands, protractor wont report pending specs
-         */
         support.forEach(kill);
         cb(err);
       }
@@ -293,9 +290,6 @@ gulp.task('test:e2e:safe', ['test:prepare', 'test:prepare:server'], (cb) => {
     let runner = exec(
       'npm run test:e2e',
       (err, stdout, stderr) => {
-        /*
-         * Note: As it stands, protractor wont report pending specs
-         */
         let match = stdout.match(/(\d+) tests?.*(\d) failures?/);
 
         testResults.push({

test/e2e/helper.js

@@ -0,0 +1,17 @@
+import fs from 'fs';
+
+// based on https://github.com/angular/protractor/issues/114#issuecomment-29046939
+afterEach(async function () {
+  let lastTest = this.currentTest;
+
+  if (lastTest.state === 'failed') {
+    let filename = `exception_${lastTest.title}.png`;
+    let png = await browser.takeScreenshot();
+    let buffer = new Buffer(png, 'base64');
+    let stream = fs.createWriteStream(filename);
+
+    stream.write(buffer);
+    stream.end();
+  }
+});
+

test/e2e/protractor.conf.js

@@ -1,10 +1,13 @@
-'use strict'
+'use strict';
+
+let chai = require('chai');
+let chaiAsPromised = require('chai-as-promised');
 
 require('babel-register');
 require('babel-polyfill');
 
 exports.config = {
-  specs: 'test/e2e/**/*.js',
+  specs: ['./helper.js', './**/*.test.js'],
   baseUrl: 'http://localhost:3003/',
   directConnect: true,
   seleniumAddress: 'http://localhost:4444/wd/hub',
@@ -13,12 +16,10 @@ exports.config = {
     reporter: 'spec',
     slow: 6000,
     timeout: 10000,
-    compilers: 'js:babel-register'
+    compilers: 'js:babel-register',
   },
   onPrepare: () => {
     browser.ignoreSynchronization = true;
-    let chai = require('chai');
-    let chaiAsPromised = require('chai-as-promised');
 
     chai.use(chaiAsPromised);
     global.expect = chai.expect;

test/e2e/static-pages/front-page.test.js

@@ -1,26 +1,9 @@
-import fs from 'fs';
-
 describe('Static Front Page', () => {
   beforeEach(() => {
     browser.get('/');
     browser.sleep(1000);
   });
 
-  // based on https://github.com/angular/protractor/issues/114#issuecomment-29046939
-  afterEach(async function () {
-    let lastTest = this.currentTest;
-
-    if (lastTest.state === 'failed') {
-      let filename = `exception_${lastTest.title}.png`;
-      let png = await browser.takeScreenshot();
-      let buffer = new Buffer(png, 'base64');
-      let stream = fs.createWriteStream(filename);
-
-      stream.write(buffer);
-      stream.end();
-    }
-  });
-
   it('shows the front page', async () => {
     let button = element(by.id('play-btn'));
     await expect(button.getText()).to.eventually.eql('Join for free');