mirror of
https://github.com/HabitRPG/habitica.git
synced 2025-12-16 14:17:22 +01:00
Improve @mention handling (#10872)
* move the update username route to v3 (#10836) * Add API Call to retrieve auto-complete options for usernames * Create links to users profile in chat messages * Begin adding server-side autocomplete to web client * Add Test to opt out of username being searchable * Fix issue with username highlighting * Correctly update message text when using autocomplete * remove old autocomplete component * Improve chat input design * rewrite mongoose migration to avoid using recursion * fixes * select more fields * use lean and .update * fix(tests): correct expects * fix(tests): linting & more expects Also one more tweak for invite validation responsiveness * chore(news): Bailey * chore(i18n): update locales * 4.70.0 * fix(chat): less intrusive highlight and better margins * fix(chat): more width tweakage * feat(content): Oddballs Bundle Also includes one more tweak to @mention text highlighting * chore(sprites): compile * chore(i18n): update locales * 4.71.0 * groupChatReceived webhook fix (#10802) * Moved sendGroupChatReceivedWebhooks to group.sendChat function. * Added test for new functionality. * Set width on .custom-control-label (#10840) Set `width: 100%` on the `.custom-control-label`. Although `overflow-wrap: break-word` is set on the parent `.checklist-item` element, it doesn't seem to take effect unless a width is set on the label. * Very large Guild member counts overflow the badge #10753 (#10812) * Update superagent to the latest version 🚀 (#10848) * fix(package): update superagent to version 4.0.0 * chore(package): update lockfile package-lock.json * fix(chat): prevent duplicate messages, closes #10823 * Fix for #10814, prevent ParallelSave errors (#10852) * fix(group leave): prevent ParallelSave errors while leaving a group with multiple group or challenge tasks * fix typo * move computed-props to methods - refactor mountItem to use the states inside (#10853) * feat(content): Frost Hatching Potions * chore(sprites): compile * chore(i18n): update locales * 4.72.0 * fix(stable): remove progress number from petItem * add two slurs - TRIGGER / CONTENT WARNING: assault, slurs, swearwords, etc * more checks on the item.klass, also added the specialClass checks (#10859) * feat(content): Turkey Day 2018 * chore(sprites): compile * chore(i18n): update locales * 4.73.0 * chore(i18n): update locales * 4.73.1 * feat(footer): always show expanded footer (#10862) * Fixes issue #10857 ("Tags have extra space at the bottom when they should be centered") (#10861) * Fix for #10857 centered category tag text * Fixes #10857 and #10856 display tag markdown. * Attach client to chat messages (#10845) * Attach client to chat messages * Word * Design tweaks * Fix potential error * chore(event): end Thanksgiving tweaks * chore(i18n): update locales * 4.73.2 * Improve chat input design * Fix test errors * Move tier icons import to index * correctly name event variable * Debounce autocomplete calls * optimize mention highlighting * fix failing tests * Fix sending private messages * Cache username autocomplete requests * optimize autocomplete regex * Fix lint error * add optional parameters to limit autocompletion to specific group * Fix non-profile urls not being usable. * Correctly handle autocomplete for public and private guilds * Add check to make sure users don’t search for parties/guilds they are not part of * fix lint error * limit autocomplete results to 5 * fix(mentioning): change default, adapt settings control to checkbox * Improve auto completing * improve username autocomplete * Fix merge issue * remove old code * Send push notifications on mentions * Improve handling for sending mention notifications * Fix lint error * Update schema.js * Fix failing test * Don't send push notification to users who aren't in the party * Remove tributejs from dependencies
This commit is contained in:
64
test/api/unit/libs/highlightMentions.js
Normal file
64
test/api/unit/libs/highlightMentions.js
Normal file
@@ -0,0 +1,64 @@
|
||||
import {
|
||||
highlightMentions,
|
||||
} from '../../../../website/server/libs/highlightMentions';
|
||||
import mongoose from 'mongoose';
|
||||
|
||||
describe('highlightMentions', () => {
|
||||
beforeEach(() => {
|
||||
const mockFind = {
|
||||
select () {
|
||||
return this;
|
||||
},
|
||||
lean () {
|
||||
return this;
|
||||
},
|
||||
exec () {
|
||||
return Promise.resolve([{
|
||||
auth: { local: { username: 'user' } }, _id: '111',
|
||||
}, { auth: { local: { username: 'user2' } }, _id: '222',
|
||||
}, { auth: { local: { username: 'user3' } }, _id: '333',
|
||||
}, { auth: { local: { username: 'user-dash' } }, _id: '444',
|
||||
}, { auth: { local: { username: 'user_underscore' } }, _id: '555',
|
||||
},
|
||||
]);
|
||||
},
|
||||
};
|
||||
|
||||
sinon.stub(mongoose.Model, 'find').returns(mockFind);
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
sinon.restore();
|
||||
});
|
||||
|
||||
it('doesn\'t change text without mentions', async () => {
|
||||
let text = 'some chat text';
|
||||
let result = await highlightMentions(text);
|
||||
expect(result[0]).to.equal(text);
|
||||
});
|
||||
it('highlights existing users', async () => {
|
||||
let text = '@user: message';
|
||||
let result = await highlightMentions(text);
|
||||
expect(result[0]).to.equal('[@user](/profile/111): message');
|
||||
});
|
||||
it('highlights special characters', async () => {
|
||||
let text = '@user-dash: message @user_underscore';
|
||||
let result = await highlightMentions(text);
|
||||
expect(result[0]).to.equal('[@user-dash](/profile/444): message [@user_underscore](/profile/555)');
|
||||
});
|
||||
it('doesn\'t highlight nonexisting users', async () => {
|
||||
let text = '@nouser message';
|
||||
let result = await highlightMentions(text);
|
||||
expect(result[0]).to.equal('@nouser message');
|
||||
});
|
||||
it('highlights multiple existing users', async () => {
|
||||
let text = '@user message (@user2) @user3 @user';
|
||||
let result = await highlightMentions(text);
|
||||
expect(result[0]).to.equal('[@user](/profile/111) message ([@user2](/profile/222)) [@user3](/profile/333) [@user](/profile/111)');
|
||||
});
|
||||
it('doesn\'t highlight more than 5 users', async () => {
|
||||
let text = '@user @user2 @user3 @user4 @user5 @user6';
|
||||
let result = await highlightMentions(text);
|
||||
expect(result[0]).to.equal(text);
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user