fix: Account for system messages in flag slack alert

test/api/v3/unit/libs/slack.js

@@ -97,6 +97,23 @@ describe('slack', () => {
       });
     });
 
+    it('provides name for system message', () => {
+      message.uuid = 'system';
+      delete message.user;
+
+      slack.sendFlagNotification({
+        flagger,
+        group,
+        message,
+      });
+
+      expect(IncomingWebhook.prototype.send).to.be.calledWithMatch({
+        attachments: [sandbox.match({
+          author_name: 'System Message',
+        })],
+      });
+    });
+
     it('noops if no flagging url is provided', () => {
       sandbox.stub(nconf, 'get').withArgs('SLACK:FLAGGING_URL').returns('');
       sandbox.stub(logger, 'error');

website/server/libs/slack.js

@@ -25,6 +25,7 @@ function sendFlagNotification ({
     return;
   }
   let titleLink;
+  let authorName;
   let title = `Flag in ${group.name}`;
   let text = `${flagger.profile.name} (${flagger.id}) flagged a message`;
 
@@ -36,12 +37,18 @@ function sendFlagNotification ({
     title += ` - (${group.privacy} ${group.type})`;
   }
 
+  if (!message.user && message.uuid === 'system') {
+    authorName = 'System Message';
+  } else {
+    authorName = `${message.user} - ${message.uuid}`;
+  }
+
   flagSlack.send({
     text,
     attachments: [{
       fallback: 'Flag Message',
       color: 'danger',
-      author_name: `${message.user} - ${message.uuid}`,
+      author_name: authorName,
       title,
       title_link: titleLink,
       text: message.text,