krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-19 15:48:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

better distinguish between handled and not handler errors

Browse Source
This commit is contained in:
Matteo Pagliazzi
2016-05-26 23:19:29 +02:00
parent c6192dd24b
commit 10cf22cd4e
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
website/server/libs/api-v3/logger.js
View File

@@ -60,11 +60,12 @@ let loggerInterface = {
} }
let loggerArgs = [stack, errorData, ...otherArgs]; let loggerArgs = [stack, errorData, ...otherArgs];
// Treat 4xx errors as warnings, 5xx and uncaught errors as serious problems
if (!errorData || !errorData.statusCode || errorData.statusCode > 499) { // Treat 4xx errors that are handled as warnings, 5xx and uncaught errors as serious problems
if (!errorData || !errorData.isHandledError || errorData.httpCode >= 500) {
logger.error(...loggerArgs); logger.error(...loggerArgs);
} else { } else {
logger.warn(stack, errorData, ...otherArgs); logger.warn(...loggerArgs);
} }
} else { } else {
logger.error(...args); logger.error(...args);

3
website/server/middlewares/api-v3/errorHandler.js
View File

@@ -69,7 +69,8 @@ module.exports = function errorHandler (err, req, res, next) { // eslint-disable
originalUrl: req.originalUrl, originalUrl: req.originalUrl,
headers: omit(req.headers, ['x-api-key', 'cookie']), // don't send sensitive information that only adds noise headers: omit(req.headers, ['x-api-key', 'cookie']), // don't send sensitive information that only adds noise
body: req.body, body: req.body,
statusCode: responseErr.httpCode, httpCode: responseErr.httpCode,
isHandledError: responseErr.httpCode < 500,
}); });
let jsonRes = { let jsonRes = {