krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-19 15:48:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

add tests for GET challenges/:challengeId

Browse Source
This commit is contained in:
Matteo Pagliazzi
2016-02-10 16:10:00 +01:00
parent 19a709c360
commit 02a61e260b
2 changed files with 142 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
website/src/controllers/api-v3/challenges.js
View File

@@ -307,11 +307,12 @@ api.getChallenge = {
let challengeId = req.params.challengeId;
let challenge = await Challenge.findById(challengeId)
// .populate('leader', nameFields) // don't populate the group as we'll fetch it manually later
// Don't populate the group as we'll fetch it manually later
// .populate('leader', nameFields)
.exec();
if (!challenge) throw new NotFound(res.t('challengeNotFound'));
// Fetching basicGroupFields
// Fetching basic group data
let group = await Group.getGroup({user, groupId: challenge.group, fields: basicGroupFields, optionalMembership: true});
if (!group || !challenge.canView(user, group)) throw new NotFound(res.t('challengeNotFound'));