Reimplement (broken) task ordering

This commit is contained in:
Kevin Gisi
2015-04-13 07:47:56 -04:00
parent e7775c1d82
commit 02838214c7
5 changed files with 9 additions and 10 deletions

View File

@@ -44,7 +44,6 @@
"remaining": "Active", "remaining": "Active",
"complete": "Done", "complete": "Done",
"dated": "Dated", "dated": "Dated",
"datedNotSorted": "Dated To-Dos are NOT sorted by date. Sorting will probably be implemented in future.",
"due": "Due", "due": "Due",
"grey": "Grey", "grey": "Grey",
"score": "Score", "score": "Score",

View File

@@ -186,11 +186,11 @@ habitrpg.controller("ChallengesCtrl", ['$rootScope','$scope', 'Shared', 'User',
delete listDef.newTask; delete listDef.newTask;
}; };
$scope.removeTask = function(list, $index) { $scope.removeTask = function(task, list) {
if (!confirm(window.env.t('sureDelete'))) return; if (!confirm(window.env.t('sureDelete'))) return;
//TODO persist //TODO persist
// User.log({op: "delTask", data: task}); // User.log({op: "delTask", data: task});
list.splice($index, 1); _.remove(list, task);
}; };
$scope.saveTask = function(task){ $scope.saveTask = function(task){

View File

@@ -84,9 +84,9 @@ habitrpg.controller("TasksCtrl", ['$scope', '$rootScope', '$location', 'User','N
} }
}; };
$scope.removeTask = function(list, $index) { $scope.removeTask = function(task) {
if (!confirm(window.env.t('sureDelete'))) return; if (!confirm(window.env.t('sureDelete'))) return;
User.user.ops.deleteTask({params:{id:list[$index].id}}) User.user.ops.deleteTask({params:{id:task.id}})
}; };
$scope.saveTask = function(task, stayOpen, isSaveAndClose) { $scope.saveTask = function(task, stayOpen, isSaveAndClose) {

View File

@@ -66,7 +66,7 @@ script(id='templates/habitrpg-tasks.html', type="text/ng-template")
ul.task-filter ul.task-filter
li(ng-class='{active: list.view == "remaining"}') li(ng-class='{active: list.view == "remaining"}')
a(ng-click='list.view = "remaining"')=env.t('remaining') a(ng-click='list.view = "remaining"')=env.t('remaining')
li(ng-class='{active: list.view == "dated"}', tooltip=env.t('datedNotSorted')) li(ng-class='{active: list.view == "dated"}')
a(ng-click='list.view = "dated"')=env.t('dated') a(ng-click='list.view = "dated"')=env.t('dated')
li(ng-class='{active: list.view == "complete"}') li(ng-class='{active: list.view == "complete"}')
a(ng-click='list.view = "complete"')=env.t('complete') a(ng-click='list.view = "complete"')=env.t('complete')

View File

@@ -1,4 +1,4 @@
li(bindonce='list', id='task-{{::task.id}}', ng-repeat='task in obj[list.type+"s"]', class='task {{Shared.taskClasses(task, user.filters, user.preferences.dayStart, user.lastCron, list.showCompleted, main)}}', ng-click='spell && (list.type != "reward") && castEnd(task, "task", $event)', ng-class='{"cast-target":spell && (list.type != "reward"), "locked-task":obj._locked === true}', popover-trigger='mouseenter', data-popover-html="{{task.notes | markdown}}", popover-placement="top", popover-append-to-body='{{::modal ? "false":"true"}}', ng-show='shouldShow(task, list, user.preferences)') li(bindonce='list', id='task-{{::task.id}}', ng-repeat='task in obj[list.type+"s"] | orderBy:(list.view=="dated" ? "date" : nil)', class='task {{Shared.taskClasses(task, user.filters, user.preferences.dayStart, user.lastCron, list.showCompleted, main)}}', ng-click='spell && (list.type != "reward") && castEnd(task, "task", $event)', ng-class='{"cast-target":spell && (list.type != "reward"), "locked-task":obj._locked === true}', popover-trigger='mouseenter', data-popover-html="{{task.notes | markdown}}", popover-placement="top", popover-append-to-body='{{::modal ? "false":"true"}}', ng-show='shouldShow(task, list, user.preferences)')
// right-hand side control buttons // right-hand side control buttons
.task-meta-controls .task-meta-controls
@@ -44,7 +44,7 @@ li(bindonce='list', id='task-{{::task.id}}', ng-repeat='task in obj[list.type+"s
span.glyphicon.glyphicon-bullhorn(tooltip=env.t('challenge')) span.glyphicon.glyphicon-bullhorn(tooltip=env.t('challenge'))
|   |  
// delete // delete
a(ng-if='!task.challenge.id', ng-click='removeTask(obj[list.type+"s"], $index)', tooltip=env.t('delete')) a(ng-if='!task.challenge.id', ng-click='removeTask(task, obj[list.type+"s"])', tooltip=env.t('delete'))
span.glyphicon.glyphicon-trash span.glyphicon.glyphicon-trash
|   |  
@@ -101,7 +101,7 @@ li(bindonce='list', id='task-{{::task.id}}', ng-repeat='task in obj[list.type+"s
p p
a(ng-click='unlink(task, "keep")')=env.t('keepIt') a(ng-click='unlink(task, "keep")')=env.t('keepIt')
|    |   
a(ng-click="removeTask(obj[list.type+'s'], $index)")=env.t('removeIt') a(ng-click="removeTask(task, obj[list.type+'s'])")=env.t('removeIt')
div(ng-if='task.challenge.broken=="CHALLENGE_DELETED"') div(ng-if='task.challenge.broken=="CHALLENGE_DELETED"')
p p
|  |