diff --git a/package.json b/package.json index aadceeb2fd..b3f6a16acd 100644 --- a/package.json +++ b/package.json @@ -99,7 +99,6 @@ "devDependencies": { "chai": "^3.4.0", "chai-as-promised": "^5.1.0", - "chai-shallow-deep-equal": "^1.3.0", "coffee-coverage": "~0.4.2", "coveralls": "^2.11.2", "csv": "~0.3.6", diff --git a/test/api/groups/GET-groups_id.test.js b/test/api/groups/GET-groups_id.test.js index 47218baf2c..efdaadb88e 100644 --- a/test/api/groups/GET-groups_id.test.js +++ b/test/api/groups/GET-groups_id.test.js @@ -36,13 +36,12 @@ describe('GET /groups/:id', () => { it('returns the group object', () => { let api = requester(member); - return expect(api.get(`/groups/${createdGroup._id}`)) - .to.eventually.shallowDeepEqual({ - _id: createdGroup._id, - name: createdGroup.name, - type: createdGroup.type, - privacy: createdGroup.privacy, - }); + return api.get(`/groups/${createdGroup._id}`).then((group) => { + expect(group._id).to.eql(createdGroup._id); + expect(group.name).to.eql(createdGroup.name); + expect(group.type).to.eql(createdGroup.type); + expect(group.privacy).to.eql(createdGroup.privacy); + }); }); it('transforms members array to an array of user objects', () => { diff --git a/test/api/groups/POST-groups.test.js b/test/api/groups/POST-groups.test.js index f54fb7440c..ce732a0080 100644 --- a/test/api/groups/POST-groups.test.js +++ b/test/api/groups/POST-groups.test.js @@ -34,26 +34,26 @@ describe('POST /groups', () => { leaderMessage: 'Test Group Message', }; - return expect(api.post('/groups', group)) - .to.eventually.shallowDeepEqual({ - leader: leader._id, - name: group.name, - description: group.description, - leaderMessage: group.leaderMessage, - leaderOnly: group.leaderOnly, - memberCount: 1, - }).and.to.have.property('_id'); + return api.post('/groups', group).then((createdGroup) => { + expect(createdGroup._id).to.exist; + expect(createdGroup.leader).to.eql(leader._id); + expect(createdGroup.name).to.eql(group.name); + expect(createdGroup.description).to.eql(group.description); + expect(createdGroup.leaderMessage).to.eql(group.leaderMessage); + expect(createdGroup.leaderOnly).to.eql(group.leaderOnly); + expect(createdGroup.memberCount).to.eql(1); + }); }); it('returns a populated members array', () => { - return expect(api.post('/groups', { + return api.post('/groups', { type: 'party', - })).to.eventually.have.deep.property('members[0]') - .and.to.shallowDeepEqual({ - _id: leader._id, - profile: leader.profile, - contributor: leader.contributor, - }); + }).then((party) => { + let member = party.members[0]; + expect(member._id).to.eql(leader._id); + expect(member.profile).to.eql(leader.profile); + expect(member.contributor).to.eql(leader.contributor); + }); }); }); diff --git a/test/api/groups/POST-groups_id.test.js b/test/api/groups/POST-groups_id.test.js index d4553ea835..3f441387da 100644 --- a/test/api/groups/POST-groups_id.test.js +++ b/test/api/groups/POST-groups_id.test.js @@ -57,14 +57,14 @@ describe('POST /groups/:id', () => { }); it('allows user to update group', () => { - return expect(api.post(`/groups/${usersGroup._id}`, { + return api.post(`/groups/${usersGroup._id}`, { name: 'New Group Title', description: 'New group description', }).then((group) => { return api.get(`/groups/${usersGroup._id}`); - })).to.eventually.shallowDeepEqual({ - name: 'New Group Title', - description: 'New group description', + }).then((group) => { + expect(group.name).to.eql('New Group Title'); + expect(group.description).to.eql('New group description'); }); }); }); diff --git a/test/helpers/globals.helper.js b/test/helpers/globals.helper.js index 6502ac81ea..a731f1e8c2 100644 --- a/test/helpers/globals.helper.js +++ b/test/helpers/globals.helper.js @@ -5,6 +5,5 @@ global._ = require("lodash") global.chai = require("chai") chai.use(require("sinon-chai")) -chai.use(require("chai-shallow-deep-equal")); chai.use(require("chai-as-promised")); global.expect = chai.expect